daffodil icon indicating copy to clipboard operation
daffodil copied to clipboard

feat(dgeni): generate color palettes and render in design-land

Open griest024 opened this issue 1 year ago • 8 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2905

What is the new behavior?

moves lots of docs stuff to @daffodil/documentation to allow design land to access it too

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

griest024 avatar Jul 15 '24 23:07 griest024

@xelaint the styling in the design land color component definitely needs some work. I think what I have sufficiently demonstrates how to use the data available though so hopefully you can take it from here

griest024 avatar Jul 15 '24 23:07 griest024

@griest024 is this PR dependent on #2909 ?

xelaint avatar Jul 16 '24 03:07 xelaint

Yes

griest024 avatar Jul 16 '24 03:07 griest024

@griest024 can we remove $error and $daff-white from the autogenerated list? I realized they need to be reworked and should not be part of this color palettes documentation.

xelaint avatar Jul 16 '24 19:07 xelaint

@griest024 can we remove $error and $daff-white from the autogenerated list? I realized they need to be reworked and should not be part of this color palettes documentation.

will do, should any single colors ever be part of the generation or only the palettes that contain multiple shades?

griest024 avatar Jul 16 '24 22:07 griest024

I just went ahead and only gened shaded palettes since the implementation is much cleaner

griest024 avatar Jul 16 '24 23:07 griest024

@griest024 does this need to be reworked based on the changes Damien made in the last few weeks?

xelaint avatar Aug 12 '24 13:08 xelaint

@xelaint yes but afaik those changes aren't all merged yet so I will wait until they are to rebase this.

griest024 avatar Aug 12 '24 13:08 griest024

This needs to be reopened at a later time. We've substantially revised the codebase since when this was opened.

damienwebdev avatar Nov 20 '25 16:11 damienwebdev