daffodil
daffodil copied to clipboard
feat(design)!: add support for `aria-controls` to menu
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
Fixes: #2841
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No
Other information
Doesn't work if using template ref to implement menu
@damienwebdev Can we use TemplatePortal instead?
Closed for stale PR. #3998 addresses the basic accessibility support. #4159 will cover the aria-controls portion.