daffodil icon indicating copy to clipboard operation
daffodil copied to clipboard

feat(design)!: add support for `aria-controls` to menu

Open xelaint opened this issue 1 year ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2841

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

xelaint avatar Jun 21 '24 17:06 xelaint

Doesn't work if using template ref to implement menu

xelaint avatar Jul 11 '24 19:07 xelaint

@damienwebdev Can we use TemplatePortal instead?

xelaint avatar Jun 05 '25 15:06 xelaint

Closed for stale PR. #3998 addresses the basic accessibility support. #4159 will cover the aria-controls portion.

xelaint avatar Nov 04 '25 14:11 xelaint