daffodil icon indicating copy to clipboard operation
daffodil copied to clipboard

[FEAT] Type Scale Card for Docs

Open xelaint opened this issue 2 years ago • 5 comments

:bulb: Feature request

Feature Name

Type Scale Card for Docs

The Desired Behavior

The UI and implementation for type scale is written, it just needs to be moved into its own component.

Your Use Case

As a designer and developer, I would like a design component that is used to display the @daffodil/design type scales.

xelaint avatar Dec 15 '23 19:12 xelaint

@xelaint I think this is a fairly easy issue, can you expand on this issue a little more so that a new contributor could easily pick it up?

damienwebdev avatar Sep 08 '25 21:09 damienwebdev

Hey @xelaint and @damienwebdev, I’ve been trying to understand this, but I’m still a bit confused. Could you please explain it more simply?

Ron1005 avatar Sep 15 '25 06:09 Ron1005

@Ron1005 I believe, but I will let @xelaint clarify exactly where this ultimately needs to go, the Typescale cards are in the typography file in our design-land app. These components need to be exported to their own separate components and then re-used in the daffio app. How exactly we want to do this is a little unclear at the moment, since the component needs to be used in both apps.

I think a PR for converting these into a shared component exported from @daffodil/docs and then used in both daffio and design-land would be sufficient.

Let me know if you get stuck. You can also join discord if you need an assist.

damienwebdev avatar Sep 15 '25 13:09 damienwebdev

@damienwebdev TBH, the type scale card needs to be revisited since this hasn't been looked at since 2021. The current design and docs needs to be updated and should not be built out as is.

xelaint avatar Sep 15 '25 13:09 xelaint

Ok, @xelaint can you make a figma for it?

damienwebdev avatar Sep 15 '25 14:09 damienwebdev