daffodil icon indicating copy to clipboard operation
daffodil copied to clipboard

[FEAT] Add a loading state when images in a media-gallery or thumbnail are "empty"/loading.

Open damienwebdev opened this issue 6 years ago • 5 comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

When images are "empty"/loading, we currently just don't show the component.

Expected behavior

When images are "empty"/loading, we should show a "loading"-like state which is just static gray boxes. This will prevent the page from content jumping as much and will make for a better user experience. 13bdedfe-f631-4611-a487-65a9cd1c59f5

Dependent on https://github.com/graycoreio/daffodil/issues/622

What is the motivation / use case for changing the behavior?

UI Experience Improvement

Environment


Daffodil version: 1.0.0-alpha

damienwebdev avatar Jun 12 '18 14:06 damienwebdev

Greetings :wave:

Can i proceed to work on this ?

vickywane avatar Oct 15 '20 15:10 vickywane

@vickywane absolutely.

damienwebdev avatar Oct 15 '20 15:10 damienwebdev

@damienwebdev sorry i wont be able to work on this anymore. I dont have much knowledge on Angular as i more skilled on React. I also thought this was more of a styling fix but on digging deeper i can see it requires some knowledge on Angular.

My apologies for not taking a closer look before indicating my interest to work on it

vickywane avatar Oct 15 '20 17:10 vickywane

@vickywane thanks, no worries, I appreciate your interest none the less!

damienwebdev avatar Oct 15 '20 17:10 damienwebdev

Thank you.

I would keep on trying to fix this but it might not come so fast

vickywane avatar Oct 15 '20 17:10 vickywane