`gw-populate-date.php`: Fixed an issue with Populate Date Time Snippet and Read Only Time Field.

[saifsultanc]

trafficstars

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2544365356/63530?folderId=7098280

Summary

The original logic to check for AMPM is to see $inputs.length === 3. There are 3 visible fields, one for the HOURS, one for the MINUTES, and third for the AM/PM (select-dropdown). The third is rendered only when the 12hour format is enabled (i.e. AMPM enabled). It is obviously not rendered with the 24hour format.

When we are also using the GP Read Only on the Time field, it adds a hidden input. This makes the number for $inputs.length to be 3 when 24hour format is enabled. Also, it makes the value as 4 when the 12hour format is enabled. So the calculation with the 24hour format is as if AMPM is enabled See Read Only Time is trying to display 1:00 (instead of 13:00) with the 24hour format

and for the 12hour format it is as if AMPM is not enabled. See Read Only Time is trying to display 13:00 (intead of 1:00) on the 12hour format!

Instead of checking for the length, we can update to actually check if there is a select (dropdown) on the $inputs. This would be : $inputs.filter( 'select' ).length === 1. Regardless of read only or not, this will exactly tell us if there is the AM-PM dropdown or not. Update with 24 hour format:

Update with 12 hour format: