snippet-library
snippet-library copied to clipboard
gravitywiz
Fixed issue where fields using the JSON API object without filters returned no results.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2377701857/55479/
Summary
This PR addresses an issue introduced in https://github.com/gravitywiz/snippet-library/pull/677 where fields populating from the JSON API object without filters return no results. The issue was that we skipped that filter rather than indicating that all results matched that filter.
Worth noting this PR does not address the fact that the default limit of 501 is not honored by this snippet.
| Fails | |
|---|---|
| :no_entry_sign: |
Pull request title does match the correct format. The Pull Request title should match our Snippet Library Pull Request Title Guidelines in Notion. |
| :no_entry_sign: |
Commit message 'Fixed issue where fields using the JSON API object without filters returned no results.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion. |
Generated by :no_entry_sign: dangerJS against 5247f936ddb9a78bc1cb830cb0a832b48b65afcb
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
| Fails | |
|---|---|
| :no_entry_sign: |
Pull request title does match the correct format. The Pull Request title should match our Snippet Library Pull Request Title Guidelines in Notion. |
| :no_entry_sign: |
Commit message 'Fixed issue where fields using the JSON API object without filters returned no results.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion. |
Generated by :no_entry_sign: dangerJS against 5247f936ddb9a78bc1cb830cb0a832b48b65afcb