snippet-library icon indicating copy to clipboard operation
snippet-library copied to clipboard

`gpep-edit-entry.php`: Added support for workflow restarting when an entry is edited on the frontend with GPEPEE.

Open saifsultanc opened this issue 2 years ago • 4 comments
trafficstars

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2359338748/54671?folderId=3808239

Summary

With the snippet Edit Entries via Easy Passthrough snippet, Gravity Flow Workflow is not restarted. This update adds an option for that functionality.

BEFORE (Without the update): https://www.loom.com/share/db89455486434d9db3fc49ed241814bd

AFTER (With the update): https://www.loom.com/share/a921f937b45145c597b1877523365d18

saifsultanc avatar Sep 27 '23 11:09 saifsultanc

Looking good, @saifsultanc!

We'll also want to set this new option around here for clarity about which options are accepted:

https://github.com/gravitywiz/snippet-library/blob/29a724f75cec4edca130538adb7175e40c3ee4a0/gp-easy-passthrough/gpep-edit-entry.php#L29

spivurno avatar Sep 27 '23 13:09 spivurno

$this->refresh_token = rgar( $options, 'refresh_token', false );

Yikes. Forgot this final push!

saifsultanc avatar Sep 27 '23 13:09 saifsultanc

Looking good! I have a few suggestions.

workflow is a bit generic in some places such as the comments and PR title so I'd update it to Gravity Flow workflow. I think restart_workflow is fine for a parameter name, however.

Ready for re-review. PHPCS points to issues which are not part of this PR.

saifsultanc avatar Sep 28 '23 10:09 saifsultanc

Warnings
:warning: When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by :no_entry_sign: dangerJS against adbedb886233c76d504724bf3e25c10dbac5e19c

github-actions[bot] avatar Sep 28 '23 23:09 github-actions[bot]