snippet-library icon indicating copy to clipboard operation
snippet-library copied to clipboard

Fixes for count and currency parsing

Open damoncasale opened this issue 2 years ago • 1 comments
trafficstars

Context

⛑️ Ticket(s): https://secure.helpscout.net/link/to/conversation

📓 Notion: https://notion.so/link/to/card

💬 Slack: https://slack.com/link/to/thread-or-message

Summary

This is a proposed fix for the aggregate functions snippet. By default, the {count} merge tag requires that the gppa_query_all_value_objects filter return "true." Because this snippet overrides that filter, it breaks the {count} merge tag. This fix resolves that issue.

This fix also resolves an issue with parsing currency values from fields that aren't "product" fields. For instance, if we have a group of checkboxes with currency values in them, values with dollar signs or thousands separators won't be parsed properly. Feel free to modify this portion of the fix to improve currency parsing.

damoncasale avatar Sep 17 '23 05:09 damoncasale

Thanks for the PR, @damoncasale. Reviewing now. 🙂

spivurno avatar Sep 29 '23 18:09 spivurno