openstreetmap-carto icon indicating copy to clipboard operation
openstreetmap-carto copied to clipboard

Add rendering for historic=ruins

Open EdLoach opened this issue 11 years ago • 100 comments

Neither POI or area/multipolygon ruins are currently rendered. http://www.openstreetmap.org/note/114642 brought this to my attention, as the castle named in the note is already mapped as both POI and multipolygon.

For POI, perhaps just the name rendered, and for areas - well I'll let you pick a suitable colour. The wiki also suggests a lot of ways are also tagged as ruins - perhaps for these render a bit like generic barriers?

EdLoach avatar Feb 07 '14 14:02 EdLoach

Yes, there is a need for this. historic=ruins should render on the map.

thecrazychemist avatar Jun 28 '14 06:06 thecrazychemist

I guess dashed outline (as mentioned here, citing OsmAnd) could work as a visual hint.

kocio-pl avatar Sep 24 '16 19:09 kocio-pl

I don't think that works for historic=ruins. AFAIK OsmAnd uses an icon (shown in the screen) for historic=ruins. A dashed outline makes only sense for building=ruins (see https://github.com/gravitystorm/openstreetmap-carto/issues/1898).

nebulon42 avatar Sep 24 '16 19:09 nebulon42

sent from a phone

Il giorno 24 set 2016, alle ore 21:07, Michael Glanznig [email protected] ha scritto:

I don't think that works for historic=ruins.

what s the difference to archaeological site? Maybe we can use the same rendering?

dieterdreist avatar Sep 24 '16 21:09 dieterdreist

What about this icon of ruined castle, proposed for Osmic by @MaestroGlanz:

https://github.com/MaestroGlanz/osmic/blob/b6f0eaa85eedfc453e5c9b8b19ca8d1d3a89e54d/tourism/castle-ruins.svg

kocio-pl avatar Sep 23 '17 13:09 kocio-pl

Example rendering on z17: yfahggcc

kocio-pl avatar Sep 23 '17 15:09 kocio-pl

The separate shape above is implausible, what is it supposed to be?

polarbearing avatar Sep 24 '17 20:09 polarbearing

I agree that ruined castle icon is not working in practice. I guess we can use the idea of decomposed shape for something simpler, like house.

kocio-pl avatar Sep 24 '17 20:09 kocio-pl

It is directly derived from the castle icon. I could change it to a version where the parts are joined.

ghost avatar Sep 25 '17 05:09 ghost

Please try, we're still looking for something good enough.

kocio-pl avatar Sep 25 '17 11:09 kocio-pl

FWIW (different map) for nodes I went for the name and a dot, in a "historical" colour https://map.atownsend.org.uk/maps/map/map.html#zoom=17&lat=53.429972&lon=-1.26303 and for ways the name if present and a "not quite a building" colour https://map.atownsend.org.uk/maps/map/map.html#zoom=19&lat=53.122449&lon=-1.853998 and https://map.atownsend.org.uk/maps/map/map.html#zoom=20&lat=53.2699203&lon=-1.989286 .

The actual colours won't transfer to OSM Carto, but I'm not convinced you need a "characteristic" icon - the name normally describes the thing well enough.

SomeoneElseOSM avatar Sep 25 '17 14:09 SomeoneElseOSM

I have two other suggestions here: https://wiki.openstreetmap.org/w/images/a/a4/Building_ruins_generic3.svg https://wiki.openstreetmap.org/w/images/c/cb/Building_ruins_generic2.svg

You can check the appearance on https://wiki.openstreetmap.org/wiki/User:MeastroGlanz#Icons_I_created

I used 16px grid. At least, I think so.

@kocio-pl @polarbearing

ghost avatar Sep 28 '17 17:09 ghost

Still not recognizable for me at 14 px.

kocio-pl avatar Sep 28 '17 17:09 kocio-pl

I created other versions: https://wiki.openstreetmap.org/w/images/7/76/Building_ruins_generic4.svg https://wiki.openstreetmap.org/w/images/6/62/Building_ruins_generic5.svg https://wiki.openstreetmap.org/w/images/6/62/Building_ruins_generic6.svg https://wiki.openstreetmap.org/w/images/5/5d/Building_ruins_generic7.svg

All together on https://wiki.openstreetmap.org/wiki/User:MeastroGlanz#Icons_I_created

Do you have any suggestions of mixing some of the ideas?

ghost avatar Oct 02 '17 11:10 ghost

I prefer version 3 the most.

Btw. are there any icons, which should be created?

ghost avatar Oct 02 '17 11:10 ghost

Nice try, but none of them work for me at 14px (32 px would be OK). I was thinking about solid, easy to recognize shape like a simple house as a base.

kocio-pl avatar Oct 02 '17 11:10 kocio-pl

I like Building_ruins_generic6.svg... and Building_ruins_generic4.svg as well.

PontiacCZ avatar Oct 02 '17 11:10 PontiacCZ

Btw. are there any icons, which should be created?

Sure, you may for example look at #131, #152, #2518, #1870, #958, #2856...

kocio-pl avatar Oct 02 '17 11:10 kocio-pl

@PontiacCZ Try to look at 14 px version only, because that's the only thing the user will see.

kocio-pl avatar Oct 02 '17 11:10 kocio-pl

Yep, that's what I actually did, I compared icons in the "Icon original size" row on the summary page and my Firefox tells me they're 14 px wide.

Well, the more I look at the variants the more I like Building_ruins_generic6.svg (Building_ruins_generic6.svg) - the concept of one fallen tower and the other one still standing is pretty clear for me to understand it as ruins.

I am not sure, MastroGlanz, what you mean by version 3 - is it Building_ruins_generic4.svg (Building_ruins_generic4.svg)? Pretty nice as well, for me on the 2nd place.

But any of those would be better than none.

BTW kocio-pl, you have mentioned that "one of them work for me at 14px". Which one is it?

PontiacCZ avatar Oct 02 '17 12:10 PontiacCZ

I meant "none" - sorry for the typo.

6 is a nice concept, but the details are too small for me, so it looks just like 2 rectangles, with no connection to buildings.

kocio-pl avatar Oct 02 '17 12:10 kocio-pl

@PontiacCZ Have a look at the post from 4 days ago. There is 2 and 3.

ghost avatar Oct 02 '17 12:10 ghost

I added two further versions:

https://wiki.openstreetmap.org/wiki/User:MeastroGlanz#Icons_I_created

I prefer version: 3, 10, 6, 4, 2 in that order.

ghost avatar Oct 02 '17 14:10 ghost

For me 8 looks quite promising as a base:

  • the window should be bigger
  • the top should be wider/bigger
  • instead of lying part there should be "ruins" pixels (similar to 1-3 design, but without door entry)

kocio-pl avatar Oct 02 '17 14:10 kocio-pl

What about "ruined" museum icon?

historic ruins

Tomasz-W avatar Feb 22 '18 16:02 Tomasz-W

I also have a new suggestion. building_ruins_generic11

ghost avatar Feb 22 '18 20:02 ghost

@kocio-pl Can you review the proposals?

Tomasz-W avatar Mar 08 '18 19:03 Tomasz-W

None of them work for me. I was thinking about something like simple manor/house with decaying one side (just like this: https://github.com/gravitystorm/openstreetmap-carto/issues/331#issuecomment-331642349).

kocio-pl avatar Mar 08 '18 19:03 kocio-pl

You mean manor icon https://github.com/gravitystorm/openstreetmap-carto/issues/744#issuecomment-370141077 with ruined right side, yes? Did I understand correctly?

Tomasz-W avatar Mar 08 '18 19:03 Tomasz-W

Yes. The castle icon had two problems - it was too distinctive (while ruins may be very generic and not even really historic) and it has not too regular shape, so it's not easy to see the progression of decay, and it looks just like a tower with something small attached. Otherwise the idea still appeals to me.

kocio-pl avatar Mar 08 '18 19:03 kocio-pl