Andy Allan
Andy Allan
https://github.com/openstreetmap/openstreetmap-website/actions/runs/20306972690/job/58326991924 ``` SiteTest#test_tooltip_shows_for_Legend_button_on_a_layer_without_a_legend_provided: Net::ReadTimeout: Net::ReadTimeout with "Net::ReadTimeout with #" test/system/site_test.rb:33:in 'block in ' bin/rails test test/system/site_test.rb:32 ``` This was on a ruby 3.4 job, so not a Docker workflow. Let's...
Hi @anant2526, thanks for making this pull request. There are several large changes that would need to be made before we could merge this, as other people have described above....
> javascript rather than leveraging the browser history as we do now? The problem is that we don't cache the results in the browser history at all, as @lectrician1 demonstrates...
> gets stored as `@[user_id:$USER_ID]` (or something to that effect) We could use ActionText Attachments (see [this blog](https://theleafnode.com/embed-active-record-models-in-action-text/) and the [ActionText docs](https://edgeguides.rubyonrails.org/action_text_overview.html#signed-globalid)) for this.
I'd be happy to see the tests updated to use rack-test by default, and a full browser only when needed for full javascript execution. I don't think there's any noticeable...
> So it sounds like this is a solution to that but with the downside that you're really testing how the site will behave in a browser any more. I...
> I don't know if there's a way to do similar tagging with minitest * https://github.com/ordinaryzelig/minispec-metadata - but this only works if we're already using the [spec syntax](https://github.com/minitest/minitest?tab=readme-ov-file#label-Specs) which would...
Just to say that I've also seen this problem, but I don't have any opinions on the approach for a fix. @mmd-osm do you have any thoughts on the `.one`...
> It will come from https://github.com/svenfuchs/rails-i18n but some of them have been copied into our locale files I think. You might be thinking of https://github.com/openstreetmap/openstreetmap-website/issues/2255, where we brought in the...
@aceman444 Thanks for the additional details. It would be helpful if you can share the exact slovakian translations of: - A duration of time: "about 10 years" - A time...