markdown-editor icon indicating copy to clipboard operation
markdown-editor copied to clipboard

fix: subpath patterns in `exports`

Open ogonkov opened this issue 11 months ago • 4 comments

Current exports seems dosn't work at all, looks like TS just guess path with old moduleResolution, and fail to resolve anything with new moduleResolution: bundler

Trace of resolution with node10 resolution

======== Resolving module '@gravity-ui/markdown-editor/extensions/additional/Math' from '/Users/user/Projects/project/src/ui/components/common/YfmEditor/useYfmEditorOptions.ts'. ========
Explicitly specified module resolution kind: 'Node10'.
'paths' option is specified, looking for a pattern to match module name '@gravity-ui/markdown-editor/extensions/additional/Math'.
Loading module '@gravity-ui/markdown-editor/extensions/additional/Math' from 'node_modules' folder, target file types: TypeScript, Declaration.
Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.
Directory '/Users/user/Projects/project/src/ui/components/common/YfmEditor/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'gravity-ui__markdown-editor/extensions/additional/Math'
Directory '/Users/user/Projects/project/src/ui/components/common/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'gravity-ui__markdown-editor/extensions/additional/Math'
Directory '/Users/user/Projects/project/src/ui/components/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'gravity-ui__markdown-editor/extensions/additional/Math'
Directory /Users/user/Projects/project/src/ui/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'gravity-ui__markdown-editor/extensions/additional/Math'
Directory '/Users/user/Projects/project/src/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'gravity-ui__markdown-editor/extensions/additional/Math'
File '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/package.json' exists according to earlier cached lookups.
'package.json' has a 'typesVersions' entry '*' that matches compiler version '5.7.2', looking for a pattern to match module name 'extensions/additional/Math'.
Module name 'extensions/additional/Math', matched pattern 'extensions/*'.
Trying substitution './build/esm/extensions/*', candidate module location: './build/esm/extensions/additional/Math'.
File '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math.ts' does not exist.
File '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math.tsx' does not exist.
File '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math.d.ts' does not exist.
'package.json' does not have a 'typings' field.
'package.json' has 'types' field 'build/esm/index.d.ts' that references '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/build/esm/index.d.ts'.
'package.json' has a 'typesVersions' entry '*' that matches compiler version '5.7.2', looking for a pattern to match module name 'build/esm/index.d.ts'.
Loading module as file / folder, candidate module location '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/build/esm/index.d.ts', target file types: TypeScript, Declaration.
File name '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/build/esm/index.d.ts' has a '.d.ts' extension - stripping it.
File '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/index.ts' does not exist.
File '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/index.tsx' does not exist.
File '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/index.d.ts' exists - use it as a name resolution result.
Resolving real path for '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/index.d.ts', result '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/index.d.ts'.
======== Module name '@gravity-ui/markdown-editor/extensions/additional/Math' was successfully resolved to '/Users/user/Projects/project/node_modules/@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/index.d.ts' with Package ID '@gravity-ui/markdown-editor/build/esm/extensions/additional/Math/[email protected]+@diplodoc/c

ogonkov avatar Mar 04 '25 16:03 ogonkov

Preview is ready.

gravity-ui-bot avatar Mar 04 '25 16:03 gravity-ui-bot

@ogonkov is it still actual?

makhnatkin avatar Apr 29 '25 11:04 makhnatkin

I think yes, i will make changes that we discuss later

ogonkov avatar Apr 29 '25 11:04 ogonkov

Visual Tests Report is ready.

gravity-ui-bot avatar Oct 08 '25 11:10 gravity-ui-bot