netmaker icon indicating copy to clipboard operation
netmaker copied to clipboard

Fix: createExtClient()

Open DolevBaron opened this issue 2 years ago • 1 comments

The clientid supplied in the API call got discarded without ever being used, so createExtClient() could never be used with a custom client-id (until now). I simply set the matching attribute before passing it to logic.CreateExtClient(), as otherwise it will always receive a blank ClientID & generate one on its own

DolevBaron avatar Aug 09 '22 08:08 DolevBaron

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 09 '22 08:08 CLAassistant

@DolevBaron the PR will not work as written because ClientID is not in the input params for creating an ext client. This will require more work in order to merge. Did you test?

afeiszli avatar Aug 30 '22 11:08 afeiszli

I have crated a new PR with the working code for this request #1499

k4s0 avatar Aug 31 '22 09:08 k4s0

superseded by #1499

mattkasun avatar Sep 02 '22 14:09 mattkasun