netmaker icon indicating copy to clipboard operation
netmaker copied to clipboard

fix_32_64_programfiles

Open si458 opened this issue 3 years ago • 3 comments

this fixes windows 32 bit installs looking for wrong program files folder but also moves the 64 build to the correct 64bit program files

si458 avatar Jul 19 '22 19:07 si458

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 19 '22 19:07 CLAassistant

@si458 there are two problems we need to fix before merging this:

  1. the installer sets up folders in x86
  2. currently installed netclients will break, so we will need some form of upgrade logic

afeiszli avatar Jul 29 '22 14:07 afeiszli

@si458 there are two problems we need to fix before merging this:

  1. the installer sets up folders in x86
  2. currently installed netclients will break, so we will need some form of upgrade logic

Depending on the installer you can get it to pick the correct program files folder (we use advanced installer and this is possible)

But as for the upgrade logic, I tried to learn go and failed after a few hurdles as it was way to complicated sorry 😞

si458 avatar Jul 29 '22 19:07 si458

The solution is:

  fileName32 = os.Getenv("windir") + "\\System32\\wireguard.dll"
...
  path = os.Getenv("ProgramFiles") +  "\\Netclient\\"

PizzaProgram avatar Jun 19 '23 21:06 PizzaProgram