netmaker icon indicating copy to clipboard operation
netmaker copied to clipboard

[Bug]: MacOS Daemon exec path is hardcoded, fails for brew install

Open ChibangLW opened this issue 3 years ago • 1 comments
trafficstars

Contact Details

No response

What happened?

If using the netclient installed with brew the daemon fails silently. I think the error is here, where a different path is needed for homebrew installations (/opt/homebrew/bin/netclient). It also looks like /opt/homebrew/bin is needed in the path at the end.

I would expect a LaunchDeamon config depending on the exec path.

Version

v0.14.3

What OS are you using?

Mac

Relevant log output

No response

Contributing guidelines

  • [X] Yes, I did.

ChibangLW avatar Jun 17 '22 21:06 ChibangLW

I tried to modify the install code of netclient, but I have a little problem:

If we rely on brew, then install daemon logic should not be implemented in the code, so that all changes are guaranteed to be consistent;

If we do not completely rely on brew, we should do the installation logic, such as automatic installation of wireguard-go, etc.;

I prefer to complete the repair in the brew repository, and then remove the installation logic of the daemon on the mac platform (the command line can print a help prompt); brew can guarantee consistency, and brew can maintain services and things for us.

mritd avatar Jun 22 '22 01:06 mritd

Client now installs at /opt/homebrew/bin/netclient; closing this issue

afeiszli avatar Sep 22 '22 11:09 afeiszli