Chicago95 icon indicating copy to clipboard operation
Chicago95 copied to clipboard

Some icon issues

Open Dejweed opened this issue 1 year ago • 6 comments

Hello!

First of all, nice theme! Here are some things that would make it even better:

  • I've noticed that a lot of 48 icons have been upscaled poorly and now look blurry. Also some icons aren't cropped correctly (actions/22 contains many 24x24 icons, some devices/24 are 23x24 with white background), some svgs are just pngs with the .svg extension.
  • It would be nice if there were more symlinks for apps from all desktop environments, not just xfce (for now I can name archive managers like org.gnome.FileRoller, ark, lxqt-archiver...)
  • I've also noticed some minor differences with the Tux version, which could be a problem to maintain when adding new icons (Thunar toolbar as example): chicago-tux I'm not sure what would be the best thing to do, one option could be to use a script like nestoris does to link the tux icons to the default ones (he uses it for win2k/98 toggling).

Now for a bonus, you could also rename some black *-symbolic.png icons to *-symbolic.symbolic.png and they would be visible when using a dark theme, here's Nautilus as an example: Chicago-nautilus I'm currently helping nestoris with his Win98SE icon theme and if you want I can help you too, just let me know :)

Dejweed avatar Jun 19 '23 21:06 Dejweed

Honestly the icons where made a while ago using automated processes and a LOT of manual labour, would love some assistance in upgrading them and fixing them.

For the 24x24 icons some of them were just rescaled 32x32 and others were extracts where the icon itself may have been 24x23.

Either way I'd really appreciate icon upgrades, additions and better support for more non-xfce applications if you have the time.

grassmunk avatar Jun 20 '23 16:06 grassmunk

As for the Tux icons i think the easiest way to deal with that is to just make note of the specific TUX icons (which I don't think there are many), delete everything else, then make the icon theme default to Chicago95 for missing icons

grassmunk avatar Jun 20 '23 21:06 grassmunk

Alright awesome! I'll make a pull request with symlinks and maybe some icons, I won't promise too much, but I can try. Here's my attempt at xfce4-clipman-plugin 48x48: xfce4-clipman-plugin Do you have any preferences for the symlinks? For example there are gmusicbrowser, audacious and totem in the apps/48 directory, totem looks the best, is it ok if they all get linked to totem? Or are there some specific rules I should follow?

Dejweed avatar Jun 20 '23 22:06 Dejweed

That clipman looks great!

For those other icons, sounds good, those icons looks similar enough probably copy/part issue on my part.

Also, each folder has an icons.html (for example: https://github.com/grassmunk/Chicago95/blob/master/Icons/Chicago95/apps/icons.html )

If you change a bunch of icons can you rerun https://github.com/grassmunk/Chicago95/blob/master/Extras/make_html.sh in the parent folder, make viewing and seeing the icons as a whole easier.

grassmunk avatar Jun 21 '23 19:06 grassmunk

What do you think about using these icons for different views? image

Also these for zoom fit and rotate left/right image

Dejweed avatar Sep 21 '23 18:09 Dejweed

I have another suggestion: since 22x22 are usually just 16x16 expanded to 22x22, why not do the same for 24x24. This would improve consistency and authenticity, so no more blurry icons. Another thing is the HiDPI cursor. Windows includes large cursor variants, why not use those?

Dejweed avatar Nov 14 '23 20:11 Dejweed