Plus generator does not seem to generate matching GTK2 schemes

[mz1193]

I've noticed that the Plus generator does not generate matching GTK2 schemes, but rather carries over the default GTK2 folder from the base Chicago95. While this can be fixed via editing the gtkrc file on the user's end, I figured I'd mention it as a matter of more convenience when generating new themes.

[grassmunk]

So did some testing and you're right. I'm not really familiar with MATE and everything else has moved on to GTK3 (and soon 4).

I'd welcome a pull request that fixes this. The code to change the color in the theme is located at: https://github.com/grassmunk/Chicago95/blob/8fe09c856e5fc0529754444a9f49101e9829836c/Plus/pluslib.py#L1122 Adding some functionality to switch gtkrc file colors located here: https://github.com/grassmunk/Chicago95/blob/8fe09c856e5fc0529754444a9f49101e9829836c/Theme/Chicago95/gtk-2.0/gtkrc#L4

[grassmunk]

I just tested on Mate after making some small fixes to Plus (disabled xfconf query if it can't find it) and the colors work fine now. You can't just click on the installed them though, you have to click it then customize and select the correct plus theme.

The theme i used is: https://archive.org/details/win95_t2theme_202005 on Mate 20.04

[mz1193]

Sorry to bug you about this again, but all MATE components are already GTK3 at this point, and the generator was already working fine (aside from the selection preview that you noted above.) The generator still doesn't properly populate the gtkrc file in the gtk-2.0 folder with the appropriate colors, which can be seen in certain legacy programs like Pidgin and Audacious. I know that in the long term this probably doesn't matter, since GTK2 will be dropped entirely at some point, but it may be worth investigating further.

[grassmunk]

I'll mark this as a potential enhancement. Feel free to take a try at fixing.

[mz1193]

Thank you for investigating, even thought it's probably more of a "papercut" issue than anything!