graspologic icon indicating copy to clipboard operation
graspologic copied to clipboard

Added elbow marker to screeplot in plot module

Open dokato opened this issue 1 year ago • 1 comments

  • [x] Does this PR have a descriptive title that could go in our release notes?
  • [ ] ~Does this PR add any new dependencies?~
  • [x] Does this PR modify any existing APIs?
    • [x] Is the change to the API backwards compatible?
  • [ ] ~Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?~

What does this implement/fix? Briefly explain your changes.

I thought it would be nice to have an option that plots a marker with an estimated elbow at the screeplot.

Screenshot 2022-07-29 at 14 39 20

This simple PR adds it.

dokato avatar Jul 30 '22 10:07 dokato

i think this just needs auto sorting/formatting run on it

bdpedigo avatar Aug 11 '22 20:08 bdpedigo

thanks for review @bdpedigo , I think it's sorted now

dokato avatar Aug 17 '22 11:08 dokato