graspologic
graspologic copied to clipboard
graspologic-org
Give screeplot an `ax` argument
function here.
Currently no way to specify an ax, most other plotting functions have that unless there's a good reason not to. I don't see a good reason for this one not to have it. Should be pretty easy to add on.
Hi, i would like to work on this issue, shall i take it?!🙂
Sure. Just want to be able to specify a matplotlib axis if i'm using the screeplot function.
Is this work still ongoing?I am a beginner and would like to give it a try.
I think you can still PR, as it hasn't been closed. I'm going to try it as well :)
My PR is awaiting review.
On Sun, Sep 17, 2023, 8:22 AM M.liaichi @.***> wrote:
Greeting, did anyone try to PR that issue ?
— Reply to this email directly, view it on GitHub https://github.com/microsoft/graspologic/issues/840#issuecomment-1722500487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOYIALR5AB7JDVKYANSGY2TX24ISRANCNFSM5EK3IK6Q . You are receiving this because you commented.Message ID: @.***>
I'm sorry, who are you referring to?
On Mon, Sep 25, 2023, 4:24 PM M.liaichi @.***> wrote:
They should really bay attention here !
— Reply to this email directly, view it on GitHub https://github.com/microsoft/graspologic/issues/840#issuecomment-1734596048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOYIALTGN4YA7Y3WDOG2II3X4IHCRANCNFSM5EK3IK6Q . You are receiving this because you commented.Message ID: @.***>
FYI this was closed automatically since the PR was merged https://github.com/microsoft/graspologic/pull/1048 :)
