graspologic icon indicating copy to clipboard operation
graspologic copied to clipboard

Prevent double SVD computation for selectSVD

Open j1c opened this issue 5 years ago • 2 comments

Expected Behavior

SVD should be only computed once. When select_dimension is called, we already do an SVD, so no need to do it the second time once the embedding dimension is called.

Actual Behavior

SVD is done twice when using select_dimension

j1c avatar Jun 24 '19 21:06 j1c

I am interested!

dfrancisco1998 avatar Oct 30 '20 16:10 dfrancisco1998

@j1c could you explain me this ? especially the embedding dimension section.

rajpratyush avatar Apr 14 '21 04:04 rajpratyush