Results 107 issues of Marco Granelli

https://github.com/anoma/namada/blob/c0b9f68782e9d95e661e360de318c039d11b2532/crates/sdk/src/signing.rs#L69-L73 We could change the collection of public keys used for multisig public keys to a `HashSet` to avoid useless duplicates and/or the need to filter them out. A similar...

SDK
breaking:SDK

We currently validate all the transactions that we get from mempool and then we allocate the resources for the valid ones in the block. This means that we could end...

ledger
non-breaking-change

There are a couple shortcomings in the current implementation of offline signing: 1. Producing a signature with the hardware wallet is not supported 2. Producing a MASP signature is not...

cli
UX
client
MASP
SDK

MASP rewards are given out at every epoch for eligible assets tagged with the previous epoch, so that when the protocol switches to MASP epoch `x` it generates conversions for...

UX
prio:low
client
MASP
SDK
non-breaking-change

We define in the SDK `SigningTxData`, which is a support type to sign transactions, as follows: https://github.com/anoma/namada/blob/7ac415a68791245e15c22ba551b1fddb301dfbcb/crates/sdk/src/signing.rs#L65-L76 After #3883 and #3900 it seems like the `fee_payer` field is too limited....

SDK
breaking:SDK

Right now in the `tx_to_sign` method of the `TxToSign` trait we call `get_tx_to_sign` which produces a wrapper transaction. We don't need a fee payer for a genesis transaction, and indeed...

prio:low

In `finalize_block` we return the events as an ordered `Vec`. In the write log we manage them as an `IndexSet` which preserves the insertion order. In `BatchedTxResult` though we store...

ledger
breaking-change

There's a small issue with the live migration that can be done with the command: `namadan ledger run --height $BLOCK_HEIGHT --path $PATH_TO_MIGRATION_JSON_FILE --hash $JSON_FILE_HASH` The command applies the migration at...

bug
ledger

It could be a nice addition to add a query to tell how far off are we from the next epoch (or possibly MASP epoch if requested). Ideally we should...

enhancement
cli
client
SDK

Depends on #4094. Instead of retrying shielding transactions on failures when encountering an epoch change we could try to check how far we are from the next masp epoch: if...

client