graphsense-transformation icon indicating copy to clipboard operation
graphsense-transformation copied to clipboard

Align address/cluster field names

Open myrho opened this issue 3 years ago • 7 comments

I'd suggest to align address and cluster field names where they mean the same:

  • relation tables: value <> estimated_value
  • id fields: address_id <> cluster resp. address_id_group <> cluster_group (better: cluster_id and cluster_id_group)

myrho avatar Apr 27 '21 11:04 myrho

eth:

  • raw.block.block_group <> transformed.block_transactions.height_group
  • raw.block.number <> transformed.block_transactions.height <> raw.transaction.block_number

myrho avatar Apr 27 '21 13:04 myrho

Just collecting things here. Need to discuss:

  • block_transactions.txs (a list) <> address_transactions.transaction_id (a foreign key)

myrho avatar Apr 29 '21 08:04 myrho

cluster_tag_by_label column entity instead of cluster

myrho avatar May 07 '21 15:05 myrho

Updated eth_raw https://github.com/graphsense/graphsense-ethereum-etl/commit/3e3065e12f5de927ab6cacd139b08e55d175c00e

mdragaschnig avatar Jun 16 '21 11:06 mdragaschnig

utxo transformed schema:

CREATE TYPE tx_id_time (
    block_id int,
    tx_id bigint,
    timestamp int
);

vs. eth transformed schema:

CREATE TYPE tx_id_time (
    height int,
    transaction_id int,
    block_timestamp int
);

~~Please align if possible.~~ (see next comment)

myrho avatar Aug 05 '21 07:08 myrho

I think we can remove tx_id_time at all since tx needs to be looked up anyways for the tx_hash. Instead just store tx_id for first/last_tx in address/cluster table.

myrho avatar Aug 05 '21 08:08 myrho

address_transactions: timestamp and block_id could be removed also (like in the eth transformation).

myrho avatar Aug 05 '21 09:08 myrho