libgraphqlparser icon indicating copy to clipboard operation
libgraphqlparser copied to clipboard

Published 20 hours ago • verified publisher icon graphql

Add python3 support for building the lib.

Open abusi opened this issue 6 years ago • 14 comments

Hello, The idea behind this is to have libgraphql not requiring python2 for file generation but also work with python3.

CMakeLists.txt is modified in order to ask for at least python 2 and not only python 2 ast/*.py modified in order to support python2 or python3.

Thanks

abusi avatar Jul 10 '18 07:07 abusi

@abusi 👍

tsunammis avatar Jul 10 '18 07:07 tsunammis

fix all an error

haikaladnan avatar Jul 19 '18 06:07 haikaladnan

@swolchok @gjtorikian could we move forward with this pull-request?

tsunammis avatar Aug 27 '18 07:08 tsunammis

@tsunammis Why are you pinging me? I’m not a maintainer on this project, please don’t do that.

gjtorikian avatar Aug 27 '18 13:08 gjtorikian

@gjtorikian You are the second contributor, it was just a ping. Sorry.

tsunammis avatar Aug 27 '18 13:08 tsunammis

(Sorry for the delay in responding!) Isn't it possible to write code that works under both Python 2 and Python 3? I don't mind supporting Python 3, but I would rather not duplicate the generator code in order to provide that support.

swolchok avatar Sep 05 '18 23:09 swolchok

Yep, it is possible to do so. I wanted to be the less intrusive possible. But yeah i can modify the generator to be python2 and python3 compatible. Thanks.

abusi avatar Sep 06 '18 02:09 abusi

@swolchok Done, now the ast/*.py file are runable by python2 or python3. Thanks again.

abusi avatar Sep 06 '18 09:09 abusi

@swolchok I'll add diff tests with python2 and python3. Do you know if python2 and python3 are available in the travis-ci executor?

abusi avatar Sep 07 '18 09:09 abusi

Any update on this PR?

genotrance avatar Oct 26 '18 05:10 genotrance

Yeah, sorry, i'm currently on holydays, i'll finish it when i'll be back, in a week or two. Sorry for the delays.

abusi avatar Oct 26 '18 08:10 abusi

@swolchok - Are there any remaining issues preventing this PR from merging? Py2 goes away really soon and I know @abusi is maintaining a py3 fork for Tartiflette.

Thanks

bobh66 avatar Sep 20 '19 15:09 bobh66

Hi @bobh66, i cannot say that i'm maintaining a python3 fork, it's just that I stop the project from requering python 2. As i don't have any use of the 'ctypesgen'erated files, cause i use cffi, i just need the lib to built on an env whithout python2. I thought it would be cool to make the 'type generator' to run for python3 and python2 in case someone wants it. But then I had other priority at work and completly forgot about this.

abusi avatar Sep 21 '19 12:09 abusi

The missing Python 3 support is blocking the inclusion of Tartiflette into the Fedora Package Collection as libgraphqlparser is a dependency.

Would be nice if that could be resolved any time soon.

fabaff avatar May 27 '20 12:05 fabaff