graphql.github.io icon indicating copy to clipboard operation
graphql.github.io copied to clipboard

Add Subscriptions to Learn section

Open leebyron opened this issue 7 years ago â€Ē 8 comments
trafficstars

See: https://github.com/facebook/graphql/issues/334

https://graphql.org/learn/ covers Queries and Mutations but not Subscriptions.

Great task for someone who wants to contribute to the GraphQL community!

leebyron avatar Oct 02 '18 05:10 leebyron

Hi @leebyron I want to work on this Issue. How should I proceed with this? Thanks

ParthS007 avatar Oct 31 '18 04:10 ParthS007

I'm actually surprised this still isn't covered! Seems like a huge oversight, they are actually mentioned in one place but never explained?

@ParthS007 I guess you can simply follow the contribution guide in the README and create PR for it if you feel like you can take care of this...?

vnenkpet avatar Feb 20 '19 18:02 vnenkpet

@leebyron I can take this up. If no one is taking it. Have worked on subscription a lot recently and would love to contribute.

tanaypratap avatar Mar 27 '19 05:03 tanaypratap

thank

amirulazim048 avatar Apr 17 '20 02:04 amirulazim048

👋🏞 👋🏞 @ParthS007 @vnenkpet @tanaypratap Would any of you still be open to taking this on? It's still relevant and I believe it'd be an important addition to the docs. I'd be happy to help structure the page, look over the copy, etc. 😊 Or you can open a PR with your proposal, reference this issue and we can take it from there!

carolstran avatar Aug 31 '20 23:08 carolstran

@carolstran the GraphQL working committee has been talking about the doc site update for a long time now. I was wondering if there's progress in that field. We can club this and other doc related work along with it.

tanaypratap avatar Aug 31 '20 23:08 tanaypratap

@tanaypratap Ah cool, I had no idea! I'm just trying to triage some issues while I work on research for the FAQ page 😄 Is there a good way to see/track what the working committee is discussing? Or is that secret? I'm still trying to figure out the general org structure/setup ðŸĪŠ

carolstran avatar Aug 31 '20 23:08 carolstran

@carolstran you can check it out here https://github.com/graphql/graphql-wg

I haven't been able to attend the meetings for quite sometime. Last I joined, everyone, including Lee, agreed that we need an overhaul of the website.

If you run a Lighthouse test for the current website you will see the color contrast and few other things are broken too, bringing down the a11y score overall.

tanaypratap avatar Aug 31 '20 23:08 tanaypratap