graphql.github.io icon indicating copy to clipboard operation
graphql.github.io copied to clipboard

Adding link to "schema page"

Open Arthur-Milchior opened this issue 3 years ago • 8 comments

It was quite awkward that the name of a page was not a link to the page. This simply transform those words into links.

Arthur-Milchior avatar Jan 02 '22 10:01 Arthur-Milchior

CLA Not Signed

@Arthur-Milchior could you sign the CLA?

Urigo avatar Feb 15 '22 17:02 Urigo

Oops quite sorry. It seems like I forgot to end this process. I sadly need to ask permission from my employer first. I'll do it now

Arthur-Milchior avatar Feb 15 '22 18:02 Arthur-Milchior

Hi,

Sorry, I actually have multiple issue.

I tried to create an isuse on JIRA. On https://jira.linuxfoundation.org/plugins/servlet/theme/portal/4/create/143 I can't even paste anything. If I try to use ctrl+v, the cursor just disappear from the text field. If I use the link button, the URL field is emptied as soon as I leave it. Which means that I'll need to report here what I wanted to report there.

On https://contributor.easycla.lfx.linuxfoundation.org/#/cla/project/9e34f107-9fdc-4a82-981a-7159c4305665/user/c4591576-37b2-4415-bc2c-fe938fd86099?redirect=https:%2F%2Fgithub.com%2Fgraphql%2Fgraphql.github.io%2Fpull%2F1182 the link to "download PDF" for individual contributor is broken. Instead I obtain a text file with the message

{"Message":"applying watermark failed : pdfcpu: validateStringEntry: dict=FreeText entry=DA invalid type","x-request-id":"b02603e4-9585-4c2a-b4ef-6026ebd39bde"}

According to Google (my employer) feedback, they don't believe that the "GraphQL Specification Membership" should be required here. That it should be separate from the CLA itself. Is https://github.com/graphql/graphql-wg/blob/main/membership/GraphQL-Specification_Membership-2021-01-25-PREVIEW.pdf really the document to accept? It seems far bigger than a normal linux fundation CLA.

Also, your readme, with the link I just gave, misses a closing parenthesis. I would add it, but since I can't sign the CLA right now, that could not be merged either

Arthur-Milchior avatar Feb 15 '22 18:02 Arthur-Milchior

( /cc @brianwarner )

orta avatar Feb 16 '22 06:02 orta

Thank you @Arthur-Milchior (and @orta for the heads up). Both files are downloading correctly for me, can you please check if it was a transient issue?

Best, Brian

brianwarner avatar Feb 16 '22 15:02 brianwarner

Hi @brianwarner I just tested on chrome, chromium, firefox on ubuntu, and chrome on mac os, it all fail.

To be explicit, I mean the "download PDF" button on top of the green button on 2022-02-17-111318_1885x921_scrot on https://contributor.easycla.lfx.linuxfoundation.org/#/cla/project/9e34f107-9fdc-4a82-981a-7159c4305665/user/c4591576-37b2-4415-bc2c-fe938fd86099?redirect=https:%2F%2Fgithub.com%2Fgraphql%2Fgraphql.github.io%2Fpull%2F1182

The link address according to chromium is blob:https://contributor.easycla.lfx.linuxfoundation.org/67ffda1a-4830-4303-8ca2-11aa78cf882a

If it helps, I'm in Paris, France; if it's related to geolocalization or simply to find a server nearby which serves the wrong file

Arthur-Milchior avatar Feb 17 '22 10:02 Arthur-Milchior

@Arthur-Milchior can you try again? if not, we'll try again to fix it thanks!

Urigo avatar Apr 09 '23 17:04 Urigo