graphql-spec icon indicating copy to clipboard operation
graphql-spec copied to clipboard

separate out IsSubType from IsValidImplementationFieldType

Open yaacovCR opened this issue 3 years ago • 1 comments

Motivation: IsSubType could be re-used within ResolveAbstractType when its behavior is clarified. See: #973.

yaacovCR avatar Aug 02 '22 01:08 yaacovCR

Deploy Preview for graphql-spec-draft ready!

Name Link
Latest commit 2884863ac1368038d410fa9cd6ab0f96730b0e19
Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/62e87be02aedfb00086feba1
Deploy Preview https://deploy-preview-977--graphql-spec-draft.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 02 '22 01:08 netlify[bot]

Nice!

Confirming that this aligns to the existing https://github.com/graphql/graphql-js/blob/main/src/type/schema.ts#L311 in the ref impl.

This IsValidImplementationFieldType() is in large part directly mapping to https://github.com/graphql/graphql-js/blob/a24a9f35b876bdd0d5050eca34d3020bd0db9a29/src/utilities/typeComparators.ts#L38 which maps well to the change you proposed

leebyron avatar Sep 01 '22 19:09 leebyron