graphql-relay-js icon indicating copy to clipboard operation
graphql-relay-js copied to clipboard

fix: align previous/next page flag with relay standard

Open tcleonard opened this issue 1 year ago • 3 comments

Fix issue #286 and #58

tcleonard avatar Sep 05 '22 20:09 tcleonard

CLA Missing ID CLA Not Signed

@Cito the goal of this MR is to align the computation of the page info with the relay official spec. Indeed the computation of the "has previous/next page" flags was not matching what is defined in the documentation. I have added unit tests for the missing cases. Since the standard definition can return unexpected result in some cases I left some comment to make that very explicit that it is not a bug.

tcleonard avatar Sep 05 '22 20:09 tcleonard

@tcleonard Thanks, but I'm not maintaining graphql-relay-js. Maybe @IvanGoncharov can look into this? If it gets merged, I will gladly port it over to graphql-relay-py.

Cito avatar Sep 12 '22 12:09 Cito