graphql-playground icon indicating copy to clipboard operation
graphql-playground copied to clipboard

Upgrade codemirror-graphql & graphiql

Open vardhanapoorv opened this issue 2 years ago • 4 comments

This PR is follow up to #1279 to get GraphQL playground ready for a release.

Changes proposed in this pull request:

  • Upgrade codemirror-graphql, graphiql, graphql

vardhanapoorv avatar Sep 18 '21 08:09 vardhanapoorv

Thanks for this! We plan on cutting another codemirror-graphql release very soon

the build issues are caused by some old dependencies - meros and fsevents, which aren’t compatible with node 14 now

I will circle back in a week or so

acao avatar Sep 18 '21 08:09 acao

Awesome thanks! I will hold off the Electron upgrade change as well then till this gets merged.

vardhanapoorv avatar Sep 18 '21 08:09 vardhanapoorv

oops! forgot about this one and created another PR with an electron upgrade as well, so it would work on my m1

acao avatar Nov 09 '21 08:11 acao

@acao no worries, let me know if I can help in anyway. Feel free to close this PR then, since you already have another PR which is more up-to-date.

vardhanapoorv avatar Nov 09 '21 14:11 vardhanapoorv