graphql-playground icon indicating copy to clipboard operation
graphql-playground copied to clipboard

Published 20 hours ago • verified publisher icon graphql

fix(#1247): Added subscriptionEndpointConnectionTimeout option

Open fiLLLip opened this issue 3 years ago • 5 comments

Forcing timeout to be set value by setting both timeout and minTimeout on the subscription client

Fixes #1247.

Changes proposed in this pull request:

  • Add new setting/property subscriptionEndpointConnectionTimeout

fiLLLip avatar Sep 30 '20 12:09 fiLLLip

@fiLLLip thanks for this! it looks like your PR just so happened to clash with one we just merged for global session headers. can you handle this merge conflict now?

acao avatar Oct 20 '20 16:10 acao

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 22 '21 18:02 CLAassistant

FYI, you can ignore the CLAassistant comment. I've disabled it for this repo since we use EasyCLA now.

brianwarner avatar Feb 22 '21 18:02 brianwarner

I did not notice your comment, @acao. I'll try to get around and check it.

@brianwarner I was just about to comment it! Is that something I have so sign?

fiLLLip avatar Feb 22 '21 18:02 fiLLLip

Yeah, the EasyCLA bot should run when you push your next commit and prompt you to sign the current documents. This one was just out of date.

brianwarner avatar Feb 22 '21 18:02 brianwarner