graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

chore(deps): upgrade dependencies

Open yaacovCR opened this issue 1 year ago • 3 comments

Errata:

Left typescript at v5.4.x as docusaurus currently conflicts with typescript v5.5.x. Left eslint v8.x as not all plugins are compatible with the new flat file config format introduced in eslint v9.x. Left at docusaurus 3.4.x as docusaurus-plugin-typedoc-api has a bug with docusaurus v3.5.x.

Code changes, in no particular order:

  1. Prettier formatting changes.
  2. Prettier moved to an async API, but the writeGeneratedFile utility, which previously included prettifying was passed as a callback function to TS and had to stay sync, so prettifying was separated into a separate async function -- the callback function luckily did not seem to actually requiring another round of prettifying, as it just involved renaming. All the other callsites of the new utility had to be made async. In the alternate, I investigated @prettier/sync and the lower-level make-synchronized and make-synchronous packages, but I could not get them working.
  3. Plenty of eslint rule changes! I have tried to make sure that the rule list orders now match the linked documentation, so that further updates might be easier.
  4. Minor docusaurus config tweaks to get the build to pass.

yaacovCR avatar Aug 16 '24 05:08 yaacovCR

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

github-actions[bot] avatar Aug 16 '24 05:08 github-actions[bot]

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 4e76da055747a3e044e262188e80e339e5c84fff
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66de6aff14dbfc000874bb3e
Deploy Preview https://deploy-preview-4166--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 16 '24 05:08 netlify[bot]

@yaacovCR can we hold off on this until we merge #4165 due to the many new conflicts that will arise.

JoviDeCroock avatar Aug 16 '24 06:08 JoviDeCroock

@JoviDeCroock --

I think we can merge this now that #4171 has landed? If we do decide to go forward with #4165, my understanding is that there are no actual code changes any more from 16.x.x that will need to land, and this would only be for making the git history look pretty, so the conflicts at this point are moot?

yaacovCR avatar Sep 07 '24 18:09 yaacovCR

Updated again, this time docusaurus-plugin-typedoc-api has been upgraded to work with latest docusaurus, so I updated both of those, and I noticed that we can actually upgrade to typescript 5.5 as we get some warnings from underlying typedoc used by plugin, but website still compiles fine.

So everything upgraded except eslint, not all of our plugins support v9 even with new flat config file format disabled.

yaacovCR avatar Sep 08 '24 10:09 yaacovCR

Seems like our ci does not like typescript 5.5, may have to roll that back

yaacovCR avatar Sep 08 '24 20:09 yaacovCR