graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

fix(incremental): properly initiate nested deferred grouped field sets

Open yaacovCR opened this issue 1 year ago • 2 comments

when early execution is disabled, the shouldDefer logic has a subtle bug

see: https://github.com/graphql/defer-stream-wg/discussions/84#discussioncomment-8280294

depends on #4112

yaacovCR avatar Jun 17 '24 10:06 yaacovCR

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit a5e24f081c6721204219a9bf92e8515d2a7cb262
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6685a7dd5c09f10008a56c3c
Deploy Preview https://deploy-preview-4109--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 17 '24 10:06 netlify[bot]

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

github-actions[bot] avatar Jun 17 '24 10:06 github-actions[bot]

Closing in favor of https://github.com/graphql/graphql-js/pull/4140

yaacovCR avatar Jul 11 '24 13:07 yaacovCR