graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

do not emit pending for empty non-published subsequent results

Open yaacovCR opened this issue 2 years ago • 2 comments

The publish method checks to see if a subsequent result is empty; this same logic should be employed to suppress pending notices for empty records.

This has already been achieved for subsequent results that are children of the initial result, as we generated the pending notices from the list of initially published records.

For subsequent results that are children of other subsequent results, we previously generated the pending notice prior to actually publishing.

This change integrates the logic: the publishing method itself returns a pending notice as required. This results in a bug-fix for subsequent records of other subsequent records as well as a reduction of code for subsequent results to the initial result.

yaacovCR avatar Nov 22 '23 22:11 yaacovCR

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 4d783beecc5230d944ac9489bfd53fc74c5bd243
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/657ff8571976890008dc532c
Deploy Preview https://deploy-preview-3993--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Nov 22 '23 22:11 netlify[bot]

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

github-actions[bot] avatar Nov 22 '23 22:11 github-actions[bot]