graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

fix: cancels deferred fields when overlapping deferred results exhibits null bubbling

Open yaacovCR opened this issue 2 years ago • 2 comments

Given the following operation:

      query {
        ... @defer {
          hero {
            nonNullName
            id
          }
        }
        ... @defer {
          hero {
            nonNullName
            name
          }
        }
      }

If nonNullName returns null, the separate incremental entry with that overlapping field will error, and all the "sibling" incremental errors should also be filtered.

yaacovCR avatar Nov 07 '23 10:11 yaacovCR

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit b6b15c6ae2b5fb20d2dfe949f9d09fad34ba333b
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/654a0df2c5baad0008aed079
Deploy Preview https://deploy-preview-3983--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Nov 07 '23 10:11 netlify[bot]

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

github-actions[bot] avatar Nov 07 '23 10:11 github-actions[bot]

this additional filtering test case is fixed by the rewrite in #4026 with the test case included => it could be fixed separately prior to #4026, but I do not see the need.

yaacovCR avatar Mar 20 '24 09:03 yaacovCR