graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

Forbid @skip and @include directives in subscription root selection

Open benjie opened this issue 2 years ago • 3 comments

This is an implementation of https://github.com/graphql/graphql-spec/pull/860

The spec calls for a separate CollectSubscriptionFields algorithm due to executing without variableValues; but I figured that maintenance would be easier with the algorithms synchronized.

Please feel free to make any changes you need to this PR; it's just to get the ball rolling.

Related GraphQL WG action item (from 2021!): https://github.com/graphql/graphql-wg/issues/695

benjie avatar Oct 09 '23 19:10 benjie

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 57d7b110869ca23f8f40fd7ebd36953c11bd793a
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6524504013b5a90008d88b65
Deploy Preview https://deploy-preview-3974--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 09 '23 19:10 netlify[bot]

Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

github-actions[bot] avatar Oct 09 '23 19:10 github-actions[bot]

GraphQL v17 would be a good time to add this "breaking change" @graphql/graphql-js-reviewers

benjie avatar Oct 09 '23 20:10 benjie