graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

fix: allow async errors to bubble to AsyncIterable list items

Open yaacovCR opened this issue 3 years ago • 2 comments

Previously, async errors from further down in the tree would bubble to the parent list rather than the individual item.

This change also fixes the test so that completeValue rejects for the AsyncIterable itself -- the true intent of this test -- and not just for the nested object.

yaacovCR avatar Sep 22 '22 19:09 yaacovCR

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit efc7ee6b9e7e92278e07de2d3ed094f20a4099e1
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/632cbdec8151120008934454
Deploy Preview https://deploy-preview-3746--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 22 '22 19:09 netlify[bot]

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

github-actions[bot] avatar Sep 22 '22 19:09 github-actions[bot]