graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

feat: allow defining symbol error extensions

Open n1ru4l opened this issue 3 years ago • 1 comments

Using symbol keys is a useful approach when composing error handlers as symbol keys are omitted when the error is finally stringified.

It allows middlewares to read extensions without having to assign them to undefined afterwards or using the delete keyword.

n1ru4l avatar Sep 12 '22 12:09 n1ru4l

Hi @n1ru4l, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

github-actions[bot] avatar Sep 12 '22 12:09 github-actions[bot]

Argh; we can't have it because typescript 4.3 doesn't support symbols so it fails to pass CI. I think I must not have checked that CI had passed. Rolling back.

benjie avatar Jun 21 '24 14:06 benjie