graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

incrementalDelivery: refactoring and streamlining

Open yaacovCR opened this issue 3 years ago • 3 comments

Each commit is meant to merged separately, i.e. "Rebase and Merge" rather than "Squash and Merge"

5b8a807d: moves executeStreamField out of try block to better illustrate which code might throw 2673e3a4: introduces a new completeListItemValue function, extracted from completeListItem d987c380: uses this new function within completeAsyncIteratorValue as suggested by the TODO fda77443: tiny refactor pushing the result of handleFieldError rather than explicit null, following convention elsewhere 58eaf9d0: rename fieldPath to itemPath when dealing with items, as elsewhere 0ab22566: skip unnecessary filtering when asyncIterator's next method throws, aligning stream to non-stream

yaacovCR avatar Sep 07 '22 19:09 yaacovCR

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 4df02ca701532c38e082d37039e89d742fb1f234
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6333b26ba07d600008782b70
Deploy Preview https://deploy-preview-3728--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 07 '22 19:09 netlify[bot]

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

github-actions[bot] avatar Sep 07 '22 19:09 github-actions[bot]

this will have to come after #3746 and #3747

yaacovCR avatar Sep 22 '22 23:09 yaacovCR

completeListItemValue has been separated out into #3728 -- this is now ready for merge.

yaacovCR avatar Sep 28 '22 02:09 yaacovCR