graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

Separate validation of operation and coercion of variables into separate steps

Open IvanGoncharov opened this issue 3 years ago • 4 comments

This draft PR shows what I'm currently working on. It passes tests but fails due to lower coverage. I will try to split it into smaller commits with proper descriptions and separate discussions. The purpose of this Draft PR is to show the end goal of these smaller comments.

Any feedback/review is welcome but please keep in mind this PR is in the exploration phase (and code is still raw) so please focus only on high-level stuff.

IvanGoncharov avatar Jun 22 '22 12:06 IvanGoncharov

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 086a4f72ab03d6ce5d1b03e6952dc962c73c5344
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/62b30aa053b498000877b169
Deploy Preview https://deploy-preview-3658--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 22 '22 12:06 netlify[bot]

@github-actions publish-pr-on-npm

IvanGoncharov avatar Jun 22 '22 12:06 IvanGoncharov

@github-actions publish-pr-on-npm

@IvanGoncharov The latest changes of this PR are available on NPM as [email protected] Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR: npm install --save graphql@canary-pr-3658

github-actions[bot] avatar Jun 22 '22 12:06 github-actions[bot]

It's interesting that this change made execute faster. image

I ran it a few times and it was always faster.

IvanGoncharov avatar Jun 22 '22 13:06 IvanGoncharov