graphql-js icon indicating copy to clipboard operation
graphql-js copied to clipboard

deploy full ESM with "type": "module" in "esm" npm tag

Open PabloSzx opened this issue 4 years ago • 2 comments

I also just re-published [email protected] as [email protected] https://npm.im/graphql-esm, tested it in an example project using libraries with full ESM support https://github.com/PabloSzx/test-graphql-esm, everything works perfectly 👌

It can be tested right now doing this:

{
  "dependencies": {
    "graphql": "npm:graphql-esm@^16.0.1"
  }
}

PabloSzx avatar Nov 04 '21 03:11 PabloSzx

Also please ensure that this package works with upcoming TS 4.5 that should support esm natively and add integration tests for that.

IvanGoncharov avatar Nov 04 '21 07:11 IvanGoncharov

Looks good to me!

looks like esm tag makes sense out of band from canaries and all that

@IvanGoncharov is this ready for re-review?

yaacovCR avatar Feb 15 '22 11:02 yaacovCR

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 18f15ce6c9c626ef74c445a19c888ccebb2fe0c3
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/632a177293eb0200091946a7
Deploy Preview https://deploy-preview-3361--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 20 '22 19:09 netlify[bot]

@github-actions publish-pr-on-npm

IvanGoncharov avatar Sep 20 '22 19:09 IvanGoncharov

@github-actions publish-pr-on-npm

@IvanGoncharov The latest changes of this PR are available on NPM as graphql@17.0.0-alpha.1.canary.pr.3361.04ab27334641e170ce0e05bc927b972991953882 Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR: npm install --save graphql@canary-pr-3361

github-actions[bot] avatar Sep 20 '22 19:09 github-actions[bot]

I rebased this PR to the latest main as the solution for #3603

IvanGoncharov avatar Sep 20 '22 20:09 IvanGoncharov

@IvanGoncharov @PabloSzx et al

question about the current state => the build scripts add a build qualifier of "+esm" and a tag suffix of "-esm", but do not rename the package to graphql-esm => the integration tests that use graphql-esm just point to a local tarball with the distribution, presumably where the name of the package is still graphql.

Over at the graphql-esm on npm -- it doesn't seem like we have used the exact machinery within this repo to publish as on npm graphql-esm is up to 16.5 and the tag is just 'latest' not 'latest-esm'.

So, where are we with this? Some options:

(1) we can get rid of the build qualifiers and tag suffix, and have a package name suffix of "-esm" and every time we publish to graphql, we should also publish to graphql-esm.... (2) we can get rid of the cjs version and also get rid of the build qualifiers and tag suffix.

So either way, the end goal will be to get rid of the build qualifier and tag suffix, right?

But have we decided on what will happen?

yaacovCR avatar Feb 21 '23 20:02 yaacovCR