graphiql icon indicating copy to clipboard operation
graphiql copied to clipboard

language support for `@oneOf`

Open acao opened this issue 1 year ago • 3 comments

Resolves #3678

Requires reverting https://github.com/graphql/graphiql/pull/3682

  • [x] switch devDependecies to use [email protected] for full @oneOf support
  • [ ] diagnostics support - I can't seem to get the rule to work :( - caused by #3682
  • [ ] autocompletion support - works in unit tests, but not yet in graphiql because of #3682
  • [ ] hover support
  • [x] fix all unit tests failures caused by adding a new input type to the test schema

acao avatar Sep 08 '24 17:09 acao

⚠️ No Changeset found

Latest commit: b65cda9871e69d1dc0f1c580675f1cc14a752fff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 08 '24 17:09 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.40%. Comparing base (484a9ad) to head (b65cda9). Report is 135 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3769      +/-   ##
==========================================
+ Coverage   65.32%   65.40%   +0.07%     
==========================================
  Files         122      122              
  Lines        7003     7019      +16     
  Branches     2260     2247      -13     
==========================================
+ Hits         4575     4591      +16     
  Misses       2411     2411              
  Partials       17       17              
Files with missing lines Coverage Δ
packages/graphiql-react/src/schema.tsx 82.69% <ø> (ø)
packages/graphiql/test/schema.js 42.66% <100.00%> (+4.09%) :arrow_up:
...ervice/src/interface/getAutocompleteSuggestions.ts 86.12% <100.00%> (+0.29%) :arrow_up:
...graphql-language-service/src/parser/getTypeInfo.ts 83.78% <100.00%> (+0.33%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 09 '24 17:09 codecov[bot]

Thanks for working on this. Since the last push was 10 months ago, would it make sense to rebase this against latest changes? Also, the RFC is accepted, see comment

ruudk avatar Jul 09 '25 09:07 ruudk