graphiql icon indicating copy to clipboard operation
graphiql copied to clipboard

graphiql 5: Remove `query`, `variables`, `headers` and `response` props from `<GraphiQL />`

Open dimaMachina opened this issue 1 year ago • 4 comments

per proposition https://github.com/graphql/graphiql/pull/3441#issuecomment-1813269476

dimaMachina avatar Aug 15 '24 21:08 dimaMachina

🦋 Changeset detected

Latest commit: d3c6cfd3b27986b9ad72f5d07f4d11eb58aa4abc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 15 '24 21:08 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.96%. Comparing base (7fb5ac3) to head (d3c6cfd). Report is 2 commits behind head on graphiql-5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           graphiql-5    #3735   +/-   ##
===========================================
  Coverage       63.96%   63.96%           
===========================================
  Files              35       35           
  Lines            3086     3086           
  Branches          934      934           
===========================================
  Hits             1974     1974           
  Misses           1107     1107           
  Partials            5        5           
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 15 '24 21:08 codecov[bot]

Not sure I want this change. I need this, since I am deep linking into our graphiql with a payload from query params. I decode this state and it contains query, variables and headers, and the editor must open in this state.

Would be good to see a migration path how to solve this if this API is removed.

klippx avatar Aug 19 '24 14:08 klippx

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

github-actions[bot] avatar Jun 17 '25 00:06 github-actions[bot]