migrate graphiql-explorer into the repo, ts conversion
- manually converted from flow, down to ~4 errors with
strict: false, and withstrict: trueit is about ~51 - disable, eslint and spellcheck for these files temporarily to test the integration
- adopting from the original repo https://github.com/OneGraph/graphiql-explorer as per previous discussions with onegraph
- resolve
graphiql-explorerlocally for the plugin build - split into multiple files for maintainability
to preview, see:
https://deploy-preview-3374--graphiql-test.netlify.app/webpack
also provides a typedoc
CC
@dwwoelfel and/or @sgrove , how would you like to go about this? Attribution in the readme and whatever license you chose? Or should we publish it as @graphiql/explorer under a seperate NPM module?
BCC @sachag
β οΈ No Changeset found
Latest commit: 2340812e94848fa8016f6f561376fd16699c5b72
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.
Deploy Preview for graphiql-test ready!
| Name | Link |
|---|---|
| Latest commit | f8cfaf02ce8320dee78481fdb7d10069d71575b8 |
| Latest deploy log | https://app.netlify.com/sites/graphiql-test/deploys/64c6944a247a680008f47921 |
| Deploy Preview | https://deploy-preview-3374--graphiql-test.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
Merging #3374 (2340812) into main (2348641) will increase coverage by
0.07%. Report is 19 commits behind head on main. The diff coverage is78.04%.
Additional details and impacted files
@@ Coverage Diff @@
## main #3374 +/- ##
==========================================
+ Coverage 55.75% 55.82% +0.07%
==========================================
Files 110 110
Lines 5243 5261 +18
Branches 1426 1434 +8
==========================================
+ Hits 2923 2937 +14
- Misses 1897 1900 +3
- Partials 423 424 +1
| Files | Coverage Ξ | |
|---|---|---|
| ...raphql-language-service-server/src/GraphQLCache.ts | 50.88% <50.00%> (ΓΈ) |
|
| ...ql-language-service-server/src/MessageProcessor.ts | 46.11% <50.00%> (-0.11%) |
:arrow_down: |
| ...nguage-service/src/utils/getVariablesJSONSchema.ts | 94.59% <98.38%> (+0.71%) |
:arrow_up: |
| packages/graphiql-react/src/editor/hooks.ts | 38.16% <6.25%> (-0.42%) |
:arrow_down: |
Hi @acao is anything blocking this / any way to help get this merged in?