Preserve directives on fragments when merging AST

[esquevin]

When a FragmentSpread has a directive, they used to be discarded.

Added a test and a fix. All tests passes

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: eeffefb6a9e33c79c6a7947ef72a387b7687356d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@graphiql/toolkit	Minor
@graphiql/react	Patch
graphiql	Patch
@graphiql/plugin-code-exporter	Patch
@graphiql/plugin-explorer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: esquevin / name: Guillaume Esquevin (2ec5791a15c77c80d2b350a46199ba5d25542a3f, ba50f85b2667e03d50765afe6826b19881e881e7, b2c5deb51ddd41b55c70f2d6db749572afbf8cb0, f5713410641cf137820ae481bce7d809e8511c6d, eeffefb6a9e33c79c6a7947ef72a387b7687356d)

[linux-foundation-easycla[bot]]

• :white_check_mark: login: esquevin / name: Guillaume Esquevin (174376ac8244615808bd65f0d2d13d6c9b844329, 7248821b0c43958e74f584de1bf2c120311c3cc3, 4e015d18967be8422cc04c679fc51a5a1a0a43c7)
• :white_check_mark: login: B2o5T / name: Dimitri POSTOLOV (7248821b0c43958e74f584de1bf2c120311c3cc3)
• :x: The email address for the commit (589f81950c1f25f6552f057b1b23f8396510eab2) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[acao]

awesome @esquevin, thank you ! one thing to note about signing the CLA, the email in your commits and the email you sign the CLA with have to be the same

[esquevin]

one thing to note about signing the CLA, the email in your commits and the email you sign the CLA with have to be the same

I've signed the CLA, using the proper email

On another note there seems to have been an issue in the Test PR step if the CI. I'm not familiar with this repo tooling and don't want to make a mess. What should be done now?

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dfe083a) 55.34% compared to head (eeffefb) 55.36%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3290      +/-   ##
==========================================
+ Coverage   55.34%   55.36%   +0.01%     
==========================================
  Files         115      115              
  Lines        5348     5348              
  Branches     1450     1450              
==========================================
+ Hits         2960     2961       +1     
  Misses       1962     1962              
+ Partials      426      425       -1     

Files	Coverage Δ
.../graphiql-toolkit/src/graphql-helpers/merge-ast.ts	88.13% <100.00%> (+1.69%)	:arrow_up:

[acao]

@esquevin this one is almost ready! you just need to run yarn pretty locally and it should be good to go. can you add a changeset to mark the improvement?

[linux-foundation-easycla[bot]]

• :white_check_mark: login: esquevin / name: Guillaume Esquevin (174376ac8244615808bd65f0d2d13d6c9b844329, 7248821b0c43958e74f584de1bf2c120311c3cc3, 4e015d18967be8422cc04c679fc51a5a1a0a43c7, 948c56926a9bbb99ba99301400cdf068f274bbd2)
• :white_check_mark: login: B2o5T / name: Dimitri POSTOLOV (7248821b0c43958e74f584de1bf2c120311c3cc3)
• :x: The email address for the commit (b8886a929b77e220c0763bbfd503a56ea7a9d633) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[esquevin]

@acao Seems everything is green, can I do anything to help this get merged?

[acao]

@esquevin just needs a rebase because of conflicts from the PR of yours we just merged!

[esquevin]

Everything should be good now =)

[esquevin]

@acao I believe this can be merged, let me know if it ain't the case and what I can do.

I thought it had been merged a while ago 😅 just realised now that it never made it across the finish ine