graphiql icon indicating copy to clipboard operation
graphiql copied to clipboard

monaco-editor/monaco-graphql x GraphiQL

Open dimaMachina opened this issue 2 years ago • 6 comments

related https://github.com/graphql/graphiql/issues/2326 PREVIEW

I didn't tested a lot, so some actual feature could be missing

TODO:

  • [x] Migrate codemirror editors monaco-editor

  • [x] Support monaco-graphql

  • [x] Resize works

  • [x] Configure save operations/variables/headers values to storage

  • [ ] save operationName to storage

  • [ ] color theme should be adjusted to actual codemirror color theme on dark/light mode (currently hard copied from graphiql prototype)

  • [ ] validation errors don't appear on the initial loading

  • [ ] validation error in the variables editor (related issue https://github.com/jonathanawesome/graphiql-prototype/issues/55) image

  • [ ] fix unit/e2e tests

dimaMachina avatar Jun 16 '23 22:06 dimaMachina

🦋 Changeset detected

Latest commit: f02956ada15c54eddc88c2f87d134916b73ed616

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
graphiql Major
@graphiql/react Major
monaco-graphql Major
@graphiql/plugin-code-exporter Major
@graphiql/plugin-explorer Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 16 '23 22:06 changeset-bot[bot]

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

github-actions[bot] avatar Jun 16 '23 22:06 github-actions[bot]

another thing I'll be cleaning up is a lot of no longer needed - for example, most of onHasCompletion can go, we deleted quite a bit when we added monaco in 2020

acao avatar Jul 30 '23 14:07 acao

rebased!

I will start a pre-release process for this branch. any changes we merge to this branch will be merged as a pre-release

acao avatar Jul 30 '23 15:07 acao

Deploy Preview for graphiql-test ready!

Name Link
Latest commit f02956ada15c54eddc88c2f87d134916b73ed616
Latest deploy log https://app.netlify.com/sites/graphiql-test/deploys/64c7811d10faa600083992b2
Deploy Preview https://deploy-preview-3234--graphiql-test.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 30 '23 15:07 netlify[bot]

@dimaMachina I am going to revive this, and manually re-create these changes on a new branch. I will try to keep tooling changes minimal for now

acao avatar Nov 02 '23 12:11 acao