graphiql
graphiql copied to clipboard
Cmd+K doesn't work for the docs explorer search in Firefox
in GraphiQL 2.0.2, the docs explorer has a search bar with a keyboard shortcut of "Cmd+K". Unfortunately, in Firefox the Cmd+K shortcut is already bound to opening the "omnibar" in the browser, so the page's listener for Cmd+K appears to be overridden (it seems like it might receive the event trigger, but then focus is lost when the browser triggers its own action off the keyboard shortcut).
I was able to get the Cmd+K shortcut to work fine in Safari on macOS.
graphiql version: 2.0.2
Firefox version: Nightly, 105.0a1 (2022-08-20) (64-bit)
OS: macOS 12.5.1
Oh, it actually does capture Cmd+K, but only when the user's focus is in the editor itself. Otherwise, Firefox captures the shortcut.
I think I’ll mark this as an enhancement because it should do this for a11y and other reasons, but it did not before. I think we have a global keybindings ticket somewhere already
@thomasheyenbrock meet @connorshea who contributed the headers pane amongst other bugfixes! @harshithpabbati was helping with these efforts as well iirc