[v2] keydown events bubble up too far

Open thomasheyenbrock opened this issue 3 years ago • 2 comments

Some keydown events seem to bubble up too far. One particular example is the docs search combobox. When pressing escape, the event bubbles up all the way. When rendering GraphiQL inside a dialog, this will cause the dialog to close (see example video).

https://user-images.githubusercontent.com/22288634/184151248-8ccb5290-da61-4e03-86b4-fc5fc31e1caa.mp4

Aug 11 '22 14:08 thomasheyenbrock

I love to see you proofing it and finding these edge cases! Your attention to detail has been a blessing to this project!

Aug 11 '22 18:08 acao

To be fair, a user reported this after we launched our new dashboard this week, so I didn't discover it on my own 😅

Aug 11 '22 21:08 thomasheyenbrock

Just released the fix for this in [email protected] and @graphiql/[email protected]

Sep 05 '22 10:09 thomasheyenbrock