graphiql icon indicating copy to clipboard operation
graphiql copied to clipboard

Introduce multi-root workspaces support

Open acao opened this issue 3 years ago • 6 comments

A true revert-revert thanks to my shoegun merge 😆

thank you @Foo-x for your patience and understanding, not to mention your contributions!

reverts the revert PR graphql/graphiql#2612

acao avatar Aug 01 '22 08:08 acao

🦋 Changeset detected

Latest commit: 9306f66af2245d7209d42b433c69f3dc86106d07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
vscode-graphql Patch
graphql-language-service-server Patch
graphql-language-service-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 01 '22 08:08 changeset-bot[bot]

The latest changes of this PR are available as canary in npm (based on the declared changesets):

[email protected]
[email protected]

github-actions[bot] avatar Aug 01 '22 08:08 github-actions[bot]

Codecov Report

Base: 65.70% // Head: 69.61% // Increases project coverage by +3.90% :tada:

Coverage data is based on head (73d6f68) compared to base (2d91916). Patch coverage: 23.84% of modified lines in pull request are covered.

:exclamation: Current head 73d6f68 differs from pull request most recent head 9306f66. Consider uploading reports for the commit 9306f66 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2616      +/-   ##
==========================================
+ Coverage   65.70%   69.61%   +3.90%     
==========================================
  Files          85       72      -13     
  Lines        5106     4275     -831     
  Branches     1631     1436     -195     
==========================================
- Hits         3355     2976     -379     
+ Misses       1747     1294     -453     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.66% <5.66%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 47.61% <66.66%> (+0.63%) :arrow_up:
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 01 '22 08:08 codecov[bot]

I will be ready to take a closer review of this tomorrow night, or perhaps tonight, I think there are a few small tweaks we should make. So much to juggle but this one is going to be big!

acao avatar Aug 02 '22 12:08 acao

@Foo-x did you have a fix for feature support in SDL files that had to do with document version by chance? or something else that fixes SDL files support in this PR

acao avatar Sep 03 '22 15:09 acao

@acao No, I didn't. I don't have any other changes than the PRs I created.

Foo-x avatar Sep 03 '22 16:09 Foo-x

@Foo-x just rebased it and everything is looking great. We re-released the inline operation executor, so now I'm excited to add support for workspaces! more tests and docs can follow, this is already such a great improvement!

acao avatar Oct 08 '22 23:10 acao