refactor: extract create diagnostics

[Foo-x]

Extracted the logic that creating diagnostics to a method.

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 35581eb6b426551f4369aec12d5e02af37fdf318

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov[bot]]

Codecov Report

Merging #2609 (35581eb) into main (2d91916) will increase coverage by 3.84%. The diff coverage is 23.84%.

@@            Coverage Diff             @@
##             main    #2609      +/-   ##
==========================================
+ Coverage   65.70%   69.54%   +3.84%     
==========================================
  Files          85       72      -13     
  Lines        5106     4266     -840     
  Branches     1631     1432     -199     
==========================================
- Hits         3355     2967     -388     
+ Misses       1747     1294     -453     
- Partials        4        5       +1     

Impacted Files	Coverage Δ
packages/codemirror-graphql/src/lint.ts	100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts	47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts	95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts	0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts	79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts	100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts	0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts	5.66% <5.66%> (ø)
packages/codemirror-graphql/src/variables/lint.ts	47.61% <66.66%> (+0.63%)	:arrow_up:
packages/codemirror-graphql/src/hint.ts	94.73% <100.00%> (ø)
... and 100 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5827977...35581eb. Read the comment docs.

[Foo-x]

Draft until https://github.com/graphql/graphiql/pull/2616 is merged.

[acao]

oh yes, this makes a lot of sense. let me change the base to your PR