graphiql
graphiql copied to clipboard
graphql
Disable`fillLeafsOnComplete` by default
Users found this generally annoying by default, especially when there are required arguments
Without automatically prompting autocompletion of required arguments as well as lead expansion, it makes the extension harder to use
You can now supply this in your graphql config:
config.extensions.languageService.fillLeafsOnComplete
Setting it to to true will enable this feature.
Will soon add the ability to manually enable this in monaco-graphql as well.
For both, this kind of behavior would be better as a keyboard command, context menu item &/or codelens prompt. We could even re-create the graphiql behavior for this, where after choosing an autocomplete item, CMD + return will automatically fill leaf fields
🦋 Changeset detected
Latest commit: e385cc0612fdae5d3e0db426e9f2cdf84049b86b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
| Name | Type |
|---|---|
| graphql-language-service-server | Patch |
| monaco-graphql | Patch |
| vscode-graphql | Patch |
| graphql-language-service-cli | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest changes of this PR are available as canary in npm (based on the declared changesets):
[email protected]
[email protected]
[email protected]
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@stonexer what do you think - updating these tests with minor changes to the language service are cumbersome to the point that I wonder if snapshot tests would be more ideal sometimes?
the snapshot diffs would tell us everything we need to know about the changes. and then i could remove the boilerplate for asserting the expected output
I also think the snapshot test might be more efficient on the language service. And we can be a little more detailed when we review the snapshot diff.
