graphiql icon indicating copy to clipboard operation
graphiql copied to clipboard

draft: merge webpack to vite

Open rxliuli opened this issue 3 years ago • 15 comments

ref: https://github.com/graphql/graphiql/pull/2323#issuecomment-1104859303

rxliuli avatar Apr 22 '22 05:04 rxliuli

⚠️ No Changeset found

Latest commit: 1a0a3efad699dab9e78d70b0350490b8a0202e1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 22 '22 05:04 changeset-bot[bot]

Codecov Report

Merging #2371 (1c0b702) into main (2d91916) will decrease coverage by 0.98%. The diff coverage is 73.64%.

:exclamation: Current head 1c0b702 differs from pull request most recent head 1a0a3ef. Consider uploading reports for the commit 1a0a3ef to get more accurate results

@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
- Coverage   65.70%   64.72%   -0.99%     
==========================================
  Files          85       81       -4     
  Lines        5106     5321     +215     
  Branches     1631     1703      +72     
==========================================
+ Hits         3355     3444      +89     
- Misses       1747     1873     +126     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a09a7fa...1a0a3ef. Read the comment docs.

codecov[bot] avatar Apr 22 '22 06:04 codecov[bot]

I plan on coming back to this FYI! I have no wifi at home but now I'm at the office, so I may be able to put more time into helping you on this!

acao avatar Apr 26 '22 08:04 acao

I plan on coming back to this FYI! I have no wifi at home but now I'm at the office, so I may be able to put more time into helping you on this!

I don't have much time before 05.01, work content must be delivered by the 30th(deadline), maybe I will have some time to deal with the 5.1-5.5 holiday

rxliuli avatar Apr 26 '22 09:04 rxliuli

If you like! Would it be ok if I made some commits this week if I have some time?

acao avatar Apr 26 '22 19:04 acao

Sorry it’s been a long time! But I would love to revive this PR and finish this up to help out the upstream graphiql2 and users who need more/ new formats. @jonathanawesome you may be interested in tinkering with this as well!

acao avatar Jul 28 '22 20:07 acao

Sorry, I haven't been motivated to do this since using Apollo explorer https://studio.apollographql.com/sandbox/explorer

rxliuli avatar Jul 29 '22 00:07 rxliuli

Hello @acao any plans to revive this?

shabab477 avatar Aug 01 '22 08:08 shabab477

yes @shabab477 I was hoping someone would! just have not had time but was hoping to get to it in the next month or so. I would welcome any PRs towards a move to pnpm and move all library builds to esbuild & vite, and upgrade webpack example(s) to 5 and update vite examples etc.

I would also be open to any monorepo tooling suggestions as well, rush, moonrepo, turbobuild, nx.dev, etc. if we can replace a monorepo-wide incremental build/watch dev experience like we partially have with typescript project references that would be awesome. We used to have project refs working entirely across the monorepo before i ntroduced vite to graphiql and graphiql/react in an awkward way. @thomasheyenbrock has done his best with this setup and made some improvements, but I would love to give him and other graphiql maintainers and contributors a much better experience!

acao avatar Aug 01 '22 08:08 acao

@rxliuli i hope it's ok if we re-open your PR for reference as we make the migration?

acao avatar Aug 01 '22 08:08 acao

@rxliuli i hope it's ok if we re-open your PR for reference as we make the migration?

Of course, feel free to use

rxliuli avatar Aug 01 '22 08:08 rxliuli

@rxliuli thank you and thank you for this helpful draft PR! I'm happy you found a tool that works for you. GraphQL is the only mission!

acao avatar Aug 01 '22 08:08 acao

@shabab477 let me know if and when you'd like to take this on! I am happy to help in whatever capacity, and am happy to schedule a time to learn about the repo if you have question.

I just want to get a few more releases out to the LSP, and some fixes for graphiql@1 before i dive down this important but inevitably complex "rabbit hole" haha

acao avatar Aug 01 '22 17:08 acao

@acao I went over the repo. I'm open to work this weekend after my "usual" work 😉

shabab477 avatar Aug 01 '22 18:08 shabab477

@acao i created a PR here but seems a lot has changed(hooks instead of class components) since this commit has been made. I will have resolve the conflicts.

shabab477 avatar Aug 07 '22 07:08 shabab477