graphiql icon indicating copy to clipboard operation
graphiql copied to clipboard

[RFC] [reference] Introduce Query Params

Open harshithpabbati opened this issue 5 years ago • 8 comments

This PR introduces Query Params

Todo

  • [x] Pass query, variables through URI
  • [x] Parse through the URI to get query, variables

harshithpabbati avatar Jun 11 '20 18:06 harshithpabbati

Also, @acao looks like main branch is not configured in netlify for preview URL's

harshithpabbati avatar Jun 20 '20 15:06 harshithpabbati

@harshithpabbati fixed! this was supposed to be changed programatically in netlify.toml but it didn't seem to work. should be good now!

acao avatar Jun 20 '20 18:06 acao

@harshithpabbati idea: make this a utility in @graphiql/toolkit, that only graphql cdn.ts imports that is implemented using props somehow

acao avatar Feb 01 '21 18:02 acao

sure, will do 👍

harshithpabbati avatar Feb 03 '21 03:02 harshithpabbati

⚠️ No Changeset found

Latest commit: b00c48897d1abcafc9205878ac64e51c1819ca38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 05 '21 05:02 changeset-bot[bot]

Codecov Report

Merging #1579 (4fefbb7) into main (9223806) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1579   +/-   ##
=======================================
  Coverage   65.66%   65.66%           
=======================================
  Files          85       85           
  Lines        5115     5115           
  Branches     1624     1624           
=======================================
  Hits         3359     3359           
  Misses       1752     1752           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9223806...2774415. Read the comment docs.

codecov[bot] avatar Feb 05 '21 05:02 codecov[bot]

@harshithpabbati thanks for implementing this in the RFC as well!

acao avatar Feb 06 '21 16:02 acao

@thomasheyenbrock @jonathanawesome I think this one is really important to address in 2.0.0!

Users have long requested a configurable and safe way to handle query params, but most in their implementations are left up to them. The expectation of query, variables and a few other safe parameters (http request url is safe now) to come with GraphiQL is quite standard now, but it's not actually implemented!

acao avatar Jul 28 '22 17:07 acao